Adds aria-label to breadcrumb truncation toggle #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds the missing
aria-labelattribute to the breadcrumb component's truncation button.🛠️ Detailed description
Because the truncation toggle button has only an icon inside of it (hidden with
aria-hidden=true), the button is required to have anaria-labelto supply the button element with an accessible name.This changes nothing that is visually rendered in the browser.
I've also added a test to make sure the aria-label is always there, just in case the code is refactored in the future.
👀 Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.