Skip to content

Commit

Permalink
Merge pull request #1156 from hashicorp/alex-ju/skip-flakey-test-in-m…
Browse files Browse the repository at this point in the history
…odal

Skip flakey test in modal component
  • Loading branch information
alex-ju authored Jan 31, 2023
2 parents ac3f6d5 + 6287967 commit 9d30202
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { module, test } from 'qunit';
import { module, test, skip } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import {
click,
Expand Down Expand Up @@ -204,7 +204,7 @@ module('Integration | Component | hds/modal/index', function (hooks) {
assert.ok(opened);
});
// the following test is flakey so we're going to skip it until we find a more reliable way
test('it should call `onClose` function if provided', async function (assert) {
skip('it should call `onClose` function if provided', async function (assert) {
let closed = false;
this.set('onClose', () => (closed = true));
await render(
Expand Down

3 comments on commit 9d30202

@vercel
Copy link

@vercel vercel bot commented on 9d30202 Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on 9d30202 Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on 9d30202 Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.