Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: prevent LDS flaps in mesh gateways due to unstable datacenter lists #9651

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jan 27, 2021

Also fix a similar issue in Terminating Gateways that was masked by an
overzealous test.

(chained on #9650)

I suspect the 1.7.x backport will need to be manual.

@rboyer rboyer requested a review from a team January 27, 2021 18:06
@rboyer rboyer self-assigned this Jan 27, 2021
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Jan 27, 2021
@rboyer rboyer force-pushed the xds-mgw-sorted-filters branch from 0657feb to c6ed355 Compare January 27, 2021 20:16
@vercel vercel bot temporarily deployed to Preview – consul January 27, 2021 20:16 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 27, 2021 20:16 Inactive
@rboyer rboyer force-pushed the xds-mgw-sorted-filters branch from c6ed355 to 7097e50 Compare January 27, 2021 20:17
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 27, 2021 20:17 Inactive
@vercel vercel bot temporarily deployed to Preview – consul January 27, 2021 20:17 Inactive
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one non-blocking request

agent/xds/listeners.go Outdated Show resolved Hide resolved
Base automatically changed from xds-mgw-listener-better-dedupe to master February 5, 2021 22:28
@rboyer rboyer force-pushed the xds-mgw-sorted-filters branch from 7097e50 to a634d06 Compare February 5, 2021 22:47
@vercel vercel bot temporarily deployed to Preview – consul February 5, 2021 22:47 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 5, 2021 22:47 Inactive
Also fix a similar issue in Terminating Gateways that was masked by an
overzealous test.
@rboyer rboyer force-pushed the xds-mgw-sorted-filters branch from a634d06 to 1ac1250 Compare February 8, 2021 15:33
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging February 8, 2021 15:33 Inactive
@vercel vercel bot temporarily deployed to Preview – consul February 8, 2021 15:33 Inactive
@rboyer rboyer merged commit 43193a3 into master Feb 8, 2021
@rboyer rboyer deleted the xds-mgw-sorted-filters branch February 8, 2021 16:19
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/324185.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 43193a3 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 8, 2021
…sts (#9651)

Also fix a similar issue in Terminating Gateways that was masked by an overzealous test.
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 43193a3 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 8, 2021
…sts (#9651)

Also fix a similar issue in Terminating Gateways that was masked by an overzealous test.
rboyer added a commit that referenced this pull request Feb 8, 2021
rboyer added a commit that referenced this pull request Feb 9, 2021
rboyer added a commit that referenced this pull request Feb 9, 2021
dizzyup pushed a commit that referenced this pull request Apr 21, 2021
…sts (#9651)

Also fix a similar issue in Terminating Gateways that was masked by an overzealous test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants