Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple data races in tests #9460

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Fix a couple data races in tests #9460

merged 2 commits into from
Jan 14, 2021

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Dec 23, 2020

Related to #8329

Fixing these gets us closer to being able to enable the -race detector for all packages.

@dnephin dnephin added the theme/testing Testing, and related enhancements label Dec 23, 2020
@dnephin dnephin requested a review from a team December 23, 2020 17:43
@github-actions github-actions bot removed the theme/testing Testing, and related enhancements label Dec 23, 2020
hanshasselberg
hanshasselberg approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin dnephin added theme/testing Testing, and related enhancements backport/1.9 labels Jan 14, 2021
@dnephin dnephin merged commit 8fdc789 into master Jan 14, 2021
@dnephin dnephin deleted the dnephin/fix-data-races branch January 14, 2021 22:07
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/310695.

@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit 8fdc789 onto release/1.9.x failed! Build Log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
theme/testing Testing, and related enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnephin @hashicorp-ci @hanshasselberg