Add -domain command line flag to agent #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me 👍 |
|
Could we get an update to |
This makes it possible to configure the domain on the command line additionally to the config file.
discordianfish
force-pushed
the
add-domain-flag
branch
from
5aa38ca to
f935a8a
Compare
|
@ryanbreen Like this? |
|
Yep, LGTM! |
|
LGTM! Thanks! |
armon
added a commit
that referenced
this pull request
Mar 20, 2015
Add -domain command line flag to agent
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
* So cert is valid if calling client via pod IP rather than host IP. * Also add the host IP as a meta value to the client agent since this information is not available through Consul right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to configure the domain on the command line
additionally to the config file.
I'm not sure why some things can be specified as command line flags and other only in the config, but I think the domain is such common option that it's worth adding it to the flags. This also makes it easier to configure consul when running as docker containers.