Document some configuration for HTTPS #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the HTTPS API address can be configured just like any other address - the verify_incoming setting also applies to the HTTPS API
| @@ -546,7 +547,7 @@ definitions support being updated during a reload. | |||
| connections make use of TLS and that the client provides a certificate signed | |||
| by the Certificate Authority from the [`ca_file`](#ca_file). By default, this is false, and | |||
| Consul will not enforce the use of TLS or verify a client's authenticity. This | |||
| only applies to Consul servers since a client never has an incoming connection. | |||
| applies to both server RPC and to the HTTPS API. | |||
There was a problem hiding this comment.
I think this should still clearly indicate that it only affects server nodes. Consider
This only applies to Consul servers, since a client never has an incoming connection. It affects both the RPC and HTTPS interfaces.
|
LGTM, other than the minor suggestion above. Thanks! |
|
I think I replied too quickly on this one, sorry about that. Makes sense after a second read. Thanks! |
ryanuber
added a commit
that referenced
this pull request
Mar 18, 2015
Document some configuration for HTTPS
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
* Don't run them in parallel so that we only get one slack notification * Add gotestsum summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few configuration changes introduced by the HTTPS API feature in 0.5.0 that hadn't been written down.