Update force-leave ACL requirement to operator:write #7033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ACL requirement for
AgentForceLeave, isagent:write. This requirement doesn't really fit the endpoint given that the node that is being force left is a different node in the cluster. Whereas agent privileges are for actions an agent can take regarding its own status, such as joining or leaving the datacenter.Rather than making things significantly more complex for users by making the requirement
node:writeon the node being force-left, this PR opts for usingoperator:write, since this endpoint can remove an arbitrary number of failed nodes from the cluster.This is a breaking change and needs to go in 1.7.0, rather than a minor release.