Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Various amends for 1.7beta #6965

Merged
merged 8 commits into from
Dec 18, 2019
Merged

ui: Various amends for 1.7beta #6965

merged 8 commits into from
Dec 18, 2019

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Dec 18, 2019

This PR is a set of slight fixes (both functional and visual) ready for 1.7beta. Mainly as a result of merging 2 feature branches (namespaces and discovery chain viz) together and then integrating them:

  1. href-mut: only add a nspace if the routeName starts with dc. We know only dc-starting routes can have a nspace parameter, and this then rules out appending a nspace to the settings route.
  2. aria-menu: Change direction to orientation to match the w3c aria documentation vocab.
  3. use the same selector to select menuitems
  4. Add namespaces to disco-chain work
  5. Logging in with nspaces enabled will take you to the origin namespace for the token. There was no check to make sure namespaces where enabled or not before doing this. This adds the simplest fix, but will be further changed later down the line
  6. Tweak position of tooltips for disco chain.
  7. Slight menu padding tweaks.
  8. Increase font size of our flash-messages slightly.
  9. Keep namespace main nav menu in sync when creating a new namespace

There's potentially more to be added to the end of this but I'm PRing now to get 👀 on it as early as possible.

@johncowen johncowen requested a review from a team December 18, 2019 16:17
@johncowen johncowen added the theme/ui Anything related to the UI label Dec 18, 2019
@johncowen
Copy link
Contributor Author

johncowen commented Dec 18, 2019

This is now ready for review, we don't envisage any more commits on the end of here.

P.S. Apart from figuring out why we are now failing our tests! Sorry for the noise! All good! 🎉

@johncowen johncowen added this to the 1.7.0 milestone Dec 18, 2019
@@ -69,4 +69,22 @@ export default Route.extend({
setupController: function(controller, model) {
controller.setProperties(model);
},
actions: {
// TODO: This will eventually be deprecated please see
// https://deprecations.emberjs.com/v3.x/#toc_deprecate-router-events
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johncowen johncowen merged commit 36728b9 into ui-staging Dec 18, 2019
@johncowen johncowen deleted the feature/ui-1-7-amends branch December 18, 2019 18:27
@ghost
Copy link

ghost commented Jan 25, 2020

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.

@ghost ghost locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants