-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Various amends for 1.7beta #6965
Conversation
The backend doesn't support this as yet.
This is now ready for review, we don't envisage any more commits on the end of here.
|
@@ -69,4 +69,22 @@ export default Route.extend({ | |||
setupController: function(controller, model) { | |||
controller.setProperties(model); | |||
}, | |||
actions: { | |||
// TODO: This will eventually be deprecated please see | |||
// https://deprecations.emberjs.com/v3.x/#toc_deprecate-router-events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
This PR is a set of slight fixes (both functional and visual) ready for 1.7beta. Mainly as a result of merging 2 feature branches (namespaces and discovery chain viz) together and then integrating them:
nspace
to the settings route.direction
toorientation
to match the w3c aria documentation vocab.There's potentially more to be added to the end of this but I'm PRing now to get 👀 on it as early as possible.