Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Added labels for redhat validation into release/1.20.x #22048

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #22047 to be assessed for backporting due to the inclusion of the label backport/1.20.

The below text is copied from the body of the original PR.


Description

The CRT workflow is failing when promoting the redhat images for consul 1.20.2 release. Redhat have enforced the validations which requires the following labels to be present. These changes cater to those.

Link to failed promote workflow

Add the following labels to your Dockerfile or Containerfile: name, vendor, version, release, summary, description, maintainer and validate that they do not violate Red Hat trademark.

I can see there was an older PR which was trying to backport the changes to other versions but that seemed to have caused issues except in 1.20 hence doing the same here

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@abhishek-hashicorp abhishek-hashicorp merged commit 638ff3c into release/1.20.x Jan 3, 2025
101 of 103 checks passed
@abhishek-hashicorp abhishek-hashicorp deleted the backport/update-image-tags-redhat/duly-fit-cricket branch January 3, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants