Backport of chore: remove staff codeowners now that it requires mandatory review into release/1.20.x #22022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/rboyer/remove-staff-codeowners/definitely-modern-locust
branch
from
148f060 to
6f79607
Compare
github-team-consul-core-pr-approver
approved these changes
Dec 18, 2024
github-actions
bot
added
the
theme/contributing
sarahalsmiller
approved these changes
Dec 19, 2024
rboyer
deleted the
backport/rboyer/remove-staff-codeowners/definitely-modern-locust
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #22020 to be assessed for backporting due to the inclusion of the label backport/1.20.
The below text is copied from the body of the original PR.
Description
The staff codeowners line items were added when the codeowners files were non-mandatory, to be used as a notification only. Now that the codeowners file requires mandatory review the spirit of the original change isn't correct anymore.
Overview of commits