docs: GKE Autopilot section #20697
Merged
docs: GKE Autopilot section #20697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-yu
added
pr/no-changelog
github-actions
bot
added
the
type/docs
david-yu
added
the
backport/1.16
spacing
boruszak
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Overall LGTM.
My suggestions mostly involve using active voice. But per my comment, it's not really clear to me what you're communicating with the sentence to "customize the connectInject.apiGateway stanza to accommodate the pre-installed Gateway API CRDs." I can see the difference in the configurations, but can you add a sentence or two about what those configurations are doing/why they're important from the user's perspective?
Approving so you're not blocked. Please let me know if you if you need any additional review!
Approved on behalf of consul-docs
website/content/docs/connect/gateways/api-gateway/install-k8s.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
Co-authored-by: Jeff Boruszak <[email protected]>
This was referenced Feb 22, 2024
4 tasks
david-yu
pushed a commit
that referenced
this pull request
Feb 22, 2024
* manual backport * Update redirects.js --------- Co-authored-by: Ruben Nic <[email protected]>
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GKE Autopilot section for reference when installing Consul K8s. Update API Gateway install guide on K8s to also show GKE Autopilot install.
Testing & Reproduction steps
Links
PR Checklist