[CI-only] Build darwin artifacts on linux #19475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeggies
requested review from
dekimsey and
randyhdev
and removed request for
a team
github-actions
bot
added
type/ci
mdeggies
added
the
pr/no-changelog
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
bot
added
the
meta/stale
|
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Version 1.20 of Go fixed a significant issue affecting Consul's ability to resolve DNS correctly on MacOS when cross-compiling from linux: golang/go#12524. Building Consul darwin artifacts on Mac executors, and setting the netcgo flag, was a temporary solution to resolve this limitation in go source (introduced over in #12178). Now that Consul is being built with 1.20.10, we should be ok to remove this temporary fix.
More detail is available here: https://danp.net/posts/macos-dns-change-in-go-1-20/
Testing
Pending. Please don't review/merge until tests are complete and shared here. Thanks!