Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: Fix Kubernetes CRD example configs into release/1.16.x #19438

Merged

Conversation

blake
Copy link
Contributor

@blake blake commented Oct 30, 2023

Fixes configuration examples for several Consul Kubernetes CRDs. The CRDs were missing required fields such as apiVersion, metadata, and spec.

Description

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Fixes configuration examples for several Consul Kubernetes CRDs. The
CRDs were missing required fields such as `apiVersion`, `metadata`,
and `spec`.

Co-authored-by: Tu Nguyen <[email protected]>
@blake blake added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry labels Oct 30, 2023
@blake blake self-assigned this Oct 30, 2023
@blake blake requested a review from a team as a code owner October 30, 2023 23:32
@dhiaayachi dhiaayachi merged commit a5ca8bc into release/1.16.x Oct 31, 2023
@dhiaayachi dhiaayachi deleted the docs/backport-fix-k8s-crd-example-configs-1.16 branch October 31, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants