Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NET-1825: More new ACL token creation docs #18063
NET-1825: More new ACL token creation docs #18063
Changes from 2 commits
637b176
879bf2a
95f495c
b9eac6b
b2ae7ca
4e4d5f6
cd0c3aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean to have an agent named
agent1
? Isagent1
actually a node name in the agent configuration file? If not ... where is it defined?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a node name: https://developer.hashicorp.com/consul/docs/security/acl/acl-rules#agent-rules
I can reword this to clarify. Maybe
running on an agent with the node name `agent1`
orrunning on an agent registered as the node `agent1`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can different ESM instances share the same KV prefix? Or do they each need a unique one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intended to be shared, from what I can tell from the changelog: https://github.com/hashicorp/consul-esm/blob/fae342dfdd20e75d60b944051abafb6dbb897355/CHANGELOG.md#v030-august-9-2018