Backport of Default ProxyType for builtin extensions into release/1.16.x
#17667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/cthain/default-ext-proxy-type/lively-enabling-treefrog
branch
from
9ff9502 to
29ebc8b
Compare
hc-github-team-consul-core
force-pushed
the
backport/cthain/default-ext-proxy-type/lively-enabling-treefrog
branch
from
187beed to
21de765
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 12, 2023
hc-github-team-consul-core
deleted the
backport/cthain/default-ext-proxy-type/lively-enabling-treefrog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17657 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
This PR updates the local rate limt, Lua and property override extensions to default the
ProxyTypeinput toconnect-proxysince this is [currently] the only supported proxy type for these extensions. This aligns the default behavior across all builtin extensions that take aProxyTypeand only supportconnect-proxy.This is a non-breaking change since the config still allows setting the
ProxyTypeexpressly.Note that the docs have not been updated. I will update the docs in a separate PR once #17651 is merged.
Testing & Reproduction steps
Links
N/A
PR Checklist
Overview of commits