Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of api-gateway: stop adding all header filters to virtual host when generating xDS into release/1.16.x #17658

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17644 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

Header filters on http-route rules are being added to the virtual host and the route when generating xDS.
This is demonstrated by stepping through the commits in this PR:

  1. The first commit demonstrates the xDS that was being generated, which includes the header modifications on both the virtual host and the routes
  2. The second commit includes the fix to stop adding all header filters to the virtual host
  3. The third commit updates the golden file containing the generated xDS, so this is what we're generating after the fix

Testing & Reproduction steps

  • This PR adds a test verifying that this bug existed and is now fixed
  • The kubernetes-sigs/gateway-api conformance tests exercise this functionality, which is how I identified this bug

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/api-gateway-header-filters/reasonably-wealthy-elk branch 2 times, most recently from 5238dd0 to 31fd8c2 Compare June 12, 2023 16:06
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/api-gateway-header-filters/reasonably-wealthy-elk branch from 8204d08 to 2bb4c4b Compare June 12, 2023 16:06
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) June 12, 2023 16:06
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Jun 12, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 2750392 into release/1.16.x Jun 12, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/api-gateway-header-filters/reasonably-wealthy-elk branch June 12, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants