peering: better represent non-passing states during peer check flattening #15615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
added
the
theme/cluster-peering
hashi-derek
approved these changes
Nov 30, 2022
| api.HealthPassing: 4, | ||
| } | ||
|
|
||
| func isStatusBetter(curr, next string) bool { |
There was a problem hiding this comment.
Nit. To simplify mental-effort, I would have this function return the winning string instead of having it return a bool. Also, the name "better" makes me think that it's returning the healthier status, which is a little confusing. I'd probably name it getMostImportantStatus() or something similar.
hashi-derek
approved these changes
Nov 30, 2022
jmurret
pushed a commit
that referenced
this pull request
Dec 2, 2022
…ning (#15615) During peer stream replication we flatten checks from the source cluster and build one thin overall check to hide the irrelevant details from the consuming cluster. This flattening logic did correctly flip to non-passing if there were any non-passing checks, but WHICH status it got during that was random (warn/error). Also it didn't represent "maintenance" operations. There is an api package call AggregatedStatus which more correctly flattened check statuses. This PR replicated the more complete logic into the peer stream package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During peer stream replication we flatten checks from the source cluster and build one thin overall check to hide the irrelevant details from the consuming cluster. This flattening logic did correctly flip to non-passing if there were any non-passing checks, but WHICH status it got during that was random (warn/error).
Also it didn't represent "maintenance" operations. There is an
apipackage callAggregatedStatuswhich more correctly flattened check statuses.This PR replicated the more complete logic into the peer stream package.