Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy Integration Tests - Windows Support #15235

Closed
wants to merge 85 commits into from
Closed

Envoy Integration Tests - Windows Support #15235

wants to merge 85 commits into from

Conversation

joselo85
Copy link
Contributor

@joselo85 joselo85 commented Nov 2, 2022

Description

This PR adds support for Envoy integration tests to run in Windows. Also, adds Windows support for two consul features:

  • Enabling the consul connect envoy command to start Envoy on Windows.
  • Windows valid envoy-admin-access-log-path default value.

To run this integration tests, you need to build the required Docker images, to do so, you can use the scripts available in /build-support-windows. Documentation is also a part of this PR.

@joselo85 joselo85 requested a review from a team November 2, 2022 17:44
@joselo85 joselo85 requested a review from a team as a code owner November 2, 2022 17:44
@joselo85 joselo85 requested review from smacfarlane and jeanneryan and removed request for a team November 2, 2022 17:44
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 2, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Nov 2, 2022
@joselo85 joselo85 changed the base branch from main to windows-preview December 21, 2022 14:41
cocolavayen and others added 20 commits December 21, 2022 11:52
@cocolavayen @joselo85
[CONSUL-491] Support admin_access_log_path value for Windows (#71)
33f7414
@joselo85
[CONSUL-519] Implement mkfifo Alternative (#84)
1860c93
@joselo85
[CONSUL-542] Create OS Specific Files for Envoy Package (#88)
4c004b5
@joselo85
[CONSUL-543] Create exec_supported.go (#89)
10e86ff
@joselo85
[CONSUL-544] Test and Build Changes (#90)
4abe931
@joselo85
[CONSUL-171] Create Dockerfile (#2)
4ee6d4f
@joselo85
[CONSUL-178] Dokerfile windows test-sds-server Update Documentation (#4)
61bc874
@cocolavayen @joselo85
[CONSUL-156] Create Dockerfile (Fortio) (#3)
8aeb464
@iberlot @joselo85
[CONSUL-167] Create windows image with Socat precompiled (#1)
943874f
@iberlot @joselo85
[CONSUL-141] Support windows on main_test.go (#5)
a50a812
@joselo85
[CONSUL-186] Replace Unsupported Commands (#6)
854c6d1
@joselo85
[CONSUL-204] Support Curl on helpers.windows.bash (#9)
a2e7802
@cocolavayen @joselo85
[CONSUL-183] Create Bats Dockerfile (#8)
5587848
@ezfepo @joselo85
[CONSUL-187] Support dockerfile with consul binary (#11)
dea9dd8
@cocolavayen @joselo85
[CONSUL-207] Move base Dockerfiles to build-support-windows folder (#10)
e93feee
@ezfepo @joselo85
[CONSUL-189] Support windows consul compile script (#12)
6b9e741
@cocolavayen @joselo85
[CONSUL-210] Run Bats test and verify sh script path (#15)
0131cdd
@ezfepo @joselo85
[CONSUL-190] Support consul windows compilation in Docker (#14)
3c0f20f
@ezfepo @joselo85
[CONSUL-145] Support windows consul-envoy from envoyproxy/envoy (#13)
0787f2b
@cocolavayen @joselo85
[CONSUL-212] Create/update dummy test case using jq or curl as test o…
4a16e3c 
…utput (#17)
joselo85 and others added 27 commits December 21, 2022 11:52
@joselo85
[CONSUL-443] Create dogstatsd Function (#59)
7b10dde
@joselo85
[CONSUL-431] Update Docs Netcat (#60)
bbae5a9
@joselo85
[CONSUL-439] Parse nc Command in function (#61)
e0d981a
@joselo85
[CONSUL-463] Review curl Exec and get_ca_root Func (#63)
f0e2b44
@cocolavayen @joselo85
[CONSUL-453] Docker hostname in Helper functions (#64)
febc362
@joselo85
[CONSUL-461] Test wipe volumes without extra cont (#66)
ca3c608
@cocolavayen @joselo85
[CONSUL-454] Check ports in the Server and Agent containers (#65)
85e9033
@ezfepo @joselo85
[CONSUL-441] Update windows dockerfile with version (#62)
0a01500
@joselo85
[CONSUL-466] Review case-grpc Failing Test (#67)
80bfa8d
@joselo85
[CONSUL-494] Review case-cfg-resolver-svc-failover (#68)
b39f73f
@joselo85
[CONSUL-496] Replace docker_wget & docker_curl (#69)
99a3b55
@joselo85
[CONSUL-499] Cleanup Scripts - Remove nanoserver (#70)
6e3abfe
@joselo85
[CONSUL-500] Update Troubleshooting Docs (#72)
6fb32db
@joselo85
[CONSUL-502] Pull & Tag Envoy Windows Image (#73)
6b11b09
@joselo85
[CONSUL-504] Replace docker run in docker_consul (#76)
6203d36
@joselo85
[CONSUL-505] Change admin_bind
0d2b19a
@ezfepo @joselo85
[CONSUL-399] Update envoy to 1.23.1 (#78)
0db9f45
@joselo85
[CONSUL-510] Support case-wanfed-gw on Windows (#79)
13a5b09
@joselo85
[CONSUL-506] Update troubleshooting Documentation (#80)
895f2dc
@joselo85
[CONSUL-512] Review debug_dump_volumes Function (#81)
8c2ffcb
@joselo85
[CONSUL-514] Add zipkin to Docker Image (#82)
9c96f80
@joselo85
[CONSUL-515] Update Documentation (#83)
c0210e5
@joselo85
[CONSUL-529] Support case-consul-exec (#86)
3243d6e
@joselo85
[CONSUL-530] Update Documentation (#87)
10f2643
@ezfepo @joselo85
[CONSUL-530] Update default consul version 1.13.3
bd255c6
@joselo85
[CONSUL-539] Cleanup (#91)
6af2f31
@joselo85
[CONSUL-546] Scripts Clean-up (#92)
b9bae6f
@david-yu
Copy link
Contributor

@joselo85 Thanks for this PR! Closing as is superseded by #18007

@david-yu david-yu closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smacfarlane smacfarlane Awaiting requested review from smacfarlane

@jeanneryan jeanneryan Awaiting requested review from jeanneryan

Assignees
No one assigned
Labels
theme/cli Flags and documentation for the CLI interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joselo85 @hashicorp-cla @david-yu @cocolavayen @iberlot @ezfepo @lkysow