Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: peering #13425

Merged
merged 107 commits into from
Jun 23, 2022
Merged

ui: peering #13425

merged 107 commits into from
Jun 23, 2022

Conversation

LevelbossMike
Copy link
Contributor

@LevelbossMike LevelbossMike commented Jun 13, 2022 •
edited
Loading

Description

Adds the MVP Ui for the peering feature.

Testing & Reproduction steps

Screenshot 2022-06-22 at 13 59 14

Screenshot 2022-06-22 at 14 00 26

  • Nodes will include peered nodes

Screenshot 2022-06-22 at 14 05 07

Screenshot 2022-06-22 at 14 12 37

Screenshot 2022-06-22 at 14 18 01

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

WIP

cc @johncowen @evrowe

@LevelbossMike
add peers route
7562576
@LevelbossMike
add peers to nav
23be9e4
@LevelbossMike
use regular app ui patterns peers template
bf57f9c
@LevelbossMike
use empty state in peers UI
4a9332f
@LevelbossMike
mock v1/peerings request
6c46e37
@LevelbossMike
implement custom adapter/serializer for peers-model
ae79045
@LevelbossMike
index request for peerings on peers route
64a27db
@LevelbossMike
update peers list to show as proper list
ed08a31
@LevelbossMike
Use tailwind for easier styling
d37ef9a
@LevelbossMike
Unique ids in peerings response mock-api
2871cc0
@LevelbossMike
Add styling peerings list
9e49f0f
@LevelbossMike
Allow creating empty tooltip
405bc56 
To make it easier to iterate over a set of items where some items
should not display a tooltip and others should.
@LevelbossMike
Add tooltip Peerings:Badge
522bf60
@LevelbossMike
Add undefined peering state badge
d0af999
@LevelbossMike
Remove imported/exported services count peering
258dc67 
This won't be included in the initial version of the API response
@LevelbossMike
Implement Peerings::Search
25b9b75
@LevelbossMike
Make it possible to filter peerings by name
5d05690
@LevelbossMike
Install ember-keyboard
b687078 
For idiomatic handling of key-presses.
@LevelbossMike
Clear peering search input when pressing Escape
c13e498
@LevelbossMike
use peers.index instead of peers for peerings listing
7d61654
@LevelbossMike
Allow to include peered services in services-query
e830541
@LevelbossMike
update services mock to add peerName
338f4ba
@LevelbossMike
add Consul::Peer component
af504d6 
To surface peering information on a resource
@LevelbossMike
add PeerName as attribute to service model
3f934f6
@LevelbossMike
surface peering information in service list
532415b
@LevelbossMike
Add tooltip to Consul::Peer
5bc42ff
@LevelbossMike
Make services searchable by peer-name
28968a8
@github-actions github-actions bot added the theme/ui Anything related to the UI label Jun 13, 2022
@johncowen johncowen added the pr/no-changelog PR does not need a corresponding .changelog entry label Jun 23, 2022
@LevelbossMike LevelbossMike marked this pull request as ready for review June 23, 2022 13:08
johncowen
johncowen approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work, there were a lot of unknowns here and since this is your first major PR in Consul-land this work is great to see!

Welcome to the team! 🎉

@johncowen johncowen merged commit 5de7555 into hashicorp:main Jun 23, 2022
This was referenced Jul 7, 2022
Merged
Merged
@WenInCode WenInCode mentioned this pull request Nov 9, 2023
Merged
4 tasks
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Nov 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnwright jnwright jnwright left review comments

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
4 participants
@LevelbossMike @Amier3 @johncowen @jnwright