raft: upgrade to v1.3.6 #12496
Merged
raft: upgrade to v1.3.6 #12496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional protections on the Consul side to prevent NonVoters from bootstrapping raft. This should un-flake TestServer_Expect_NonVoters
github-actions
bot
added
the
pr/dependencies
rboyer
commented
Mar 2, 2022
| @@ -386,6 +386,11 @@ func (s *Server) maybeBootstrap() { | |||
| return | |||
| } | |||
|
|
|||
| if s.config.ReadReplica { | |||
There was a problem hiding this comment.
I put this after the check above so that it'll converge on s.config.BootstrapExpect = 0 at the same time as all of the other nodes so the rest of the loop below can handle the BootstrapExpect equality check logic properly.
kisunji
approved these changes
Mar 2, 2022
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/600304. |
rboyer
added a commit
that referenced
this pull request
Mar 2, 2022
Backport of #12496 to 1.11.x Conflicts: - go.mod
rboyer
added a commit
that referenced
this pull request
Mar 2, 2022
Backport of #12496 to 1.10.x Conflicts: - go.mod
rboyer
added a commit
that referenced
this pull request
Mar 2, 2022
Backport of #12496 to 1.11.x Conflicts: - go.mod
rboyer
added a commit
that referenced
this pull request
Mar 2, 2022
Backport of #12496 to 1.10.x Conflicts: - go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional protections on the Consul side to prevent NonVoters from bootstrapping raft.
This should un-flake
TestServer_Expect_NonVotersThe main change being incorporated by the upgrade is hashicorp/raft#492