Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding env var info #10812

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

trujillo-adam
Copy link
Contributor

@trujillo-adam trujillo-adam commented Aug 9, 2021

This PR adds information about environment variables required to use Consul Connect with Envoy when TLS is enabled.

I will make additional readability and formatting improvements to the docs in subsequent commits that are outside the scope of the issue.

I will create a separate PR to link the related tutorial to the docs changes in this PR.

@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@trujillo-adam trujillo-adam added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick pr/no-changelog PR does not need a corresponding .changelog entry labels Aug 9, 2021
@trujillo-adam trujillo-adam force-pushed the docs-envoy-proxy-breaks-when-enabling-tls branch from c4b8334 to 3fabe18 Compare August 9, 2021 20:14
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 9, 2021 20:14 Inactive
Copy link
Member

@blake blake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few minor suggestions. Otherwise, LGTM.

website/content/docs/connect/proxies/envoy.mdx Outdated Show resolved Hide resolved
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/424601.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 067c8c2 onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Aug 9, 2021
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 067c8c2 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants