Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: enable query opts on agent health and maintenance endpoints #10691

Merged
merged 2 commits into from
Jul 30, 2021
Merged

api: enable query opts on agent health and maintenance endpoints #10691

merged 2 commits into from
Jul 30, 2021

Conversation

blake
Copy link
Contributor

@blake blake commented Jul 24, 2021

This PR adds support for setting QueryOptions on the following agent API endpoints:

  • /agent/service/maintenance
  • /agent/health/service/name/:name
  • /agent/health/service/id/:id

This follows the same pattern used in #9903 to support query options for other agent API endpoints.

Resolves #9710

@blake
api: enable query opts on agent health and maintenance endpoints
3da2a42 
This PR adds support for setting QueryOptions on the following agent
API endpoints:

- /agent/health/service/name/:name
- /agent/health/service/id/:id
- /agent/service/maintenance/:id

This follows the same pattern used in #9903 to support query options
for other agent API endpoints.

Resolves #9710
@blake blake added the theme/api Relating to the HTTP API interface label Jul 24, 2021
@blake blake self-assigned this Jul 24, 2021
@blake blake mentioned this pull request Jul 24, 2021
Closed
dnephin
dnephin approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview – consul July 26, 2021 23:02 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 26, 2021 23:02 Inactive
@blake blake merged commit c919f2d into main Jul 30, 2021
@blake blake deleted the blake/api-client-health-maint-query-opts branch July 30, 2021 17:07
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/418878.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees

@blake blake

Labels
theme/api Relating to the HTTP API interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that /agent/services supports ?ns and add to API client
3 participants
@blake @hc-github-team-consul-core @dnephin