Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a single debug file for a long duration capture #10279

Merged
merged 32 commits into from
Jun 7, 2021
Merged

generate a single debug file for a long duration capture #10279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
8811b27
debug: remove the CLI check for debug_enabled
dnephin May 20, 2021
3b95fa8
remove parallel test runs
dhiaayachi May 20, 2021
c2d0334
snapshot the timestamp at the beginning of the capture
dhiaayachi May 21, 2021
2f7d538
Revert "snapshot the timestamp at the beginning of the capture"
dhiaayachi May 25, 2021
1e1a4a1
Refactor captureDynamic to extract capture logic for each item in a d…
dhiaayachi May 25, 2021
0f36a2c
snapshot the timestamp at the beginning of the capture
dhiaayachi May 21, 2021
4d93df6
Revert "snapshot the timestamp at the beginning of the capture"
dhiaayachi May 25, 2021
9a7c8da
Refactor captureDynamic to extract capture logic for each item in a d…
dhiaayachi May 25, 2021
c1ff01f
Merge branch 'dhia/debug-generate-single-file' of github.com:hashicor…
dhiaayachi May 27, 2021
84e79b6
extract wait group outside the go routine to avoid a race condition
dhiaayachi May 31, 2021
1179937
capture pprof in a separate go routine
dhiaayachi May 31, 2021
8bfe4df
perform a single capture for pprof data for the whole duration
dhiaayachi May 31, 2021
8b51b43
add missing vendor dependency
dhiaayachi May 31, 2021
c246b0e
add a change log and fix documentation to reflect the change
dhiaayachi May 31, 2021
ade9373
create function for timestamp dir creation and simplify error handling
dhiaayachi Jun 1, 2021
11360ef
use error groups and ticker to simplify interval capture loop
dhiaayachi Jun 2, 2021
a1c6505
Logs, profile and traces are captured for the full duration. Metrics,…
dhiaayachi Jun 2, 2021
0ce5c3c
refactor Logs capture routine and add log capture specific test
dhiaayachi Jun 2, 2021
d014500
improve error reporting when log test fail
dhiaayachi Jun 2, 2021
74a09e7
change test duration to 1s
dhiaayachi Jun 2, 2021
40f9294
make time parsing in log line more robust
dhiaayachi Jun 2, 2021
1249d73
refactor log time format in a const
dhiaayachi Jun 2, 2021
c471ce4
test on log line empty the earliest possible and return
dhiaayachi Jun 3, 2021
bcb2e6f
rename function to captureShortLived
dhiaayachi Jun 3, 2021
03801cd
more specific changelog
dhiaayachi Jun 3, 2021
953ceb7
update documentation to reflect current implementation
dhiaayachi Jun 3, 2021
30e14ff
add test for behavior when invalid param is passed to the command
dhiaayachi Jun 3, 2021
1b3998d
fix argument line in test
dhiaayachi Jun 4, 2021
078e69b
a more detailed description of the new behaviour
dhiaayachi Jun 7, 2021
126e8fb
print success right after the capture is done
dhiaayachi Jun 7, 2021
f9f07d9
remove an unnecessary error check
dhiaayachi Jun 7, 2021
53109bc
upgraded github.com/google/pprof v0.0.0-20181206194817-3ea8567a2e57 =…
dhiaayachi Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/10279.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
debug: capture a single stream of logs, and single pprof profile and trace for the whole duration
```
Loading