Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add a max height and scroll to the intention perm header lists #10128

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

johncowen
Copy link
Contributor

Before:

headers-before

After:

headers-after

@johncowen johncowen added theme/ui Anything related to the UI backport/1.9 labels Apr 27, 2021
@johncowen johncowen requested a review from kaxcode April 27, 2021 13:34
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen added the pr/no-changelog PR does not need a corresponding .changelog entry label Apr 29, 2021
@johncowen johncowen merged commit 5d89ba0 into master Apr 29, 2021
@johncowen johncowen deleted the ui/feature/intention-header-scroll branch April 29, 2021 09:41
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/359052.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 5d89ba0 onto release/1.10.x succeeded!

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 5d89ba0 onto release/1.9.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants