Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming] Health lookups are not case-insensitive with Streaming enabled #9702

Closed
pierresouchay opened this issue Feb 4, 2021 · 0 comments · Fixed by #9703
Closed

[Streaming] Health lookups are not case-insensitive with Streaming enabled #9702

pierresouchay opened this issue Feb 4, 2021 · 0 comments · Fixed by #9703
Labels
theme/streaming Related to Streaming connections between server and client type/bug Feature does not function as expected

Comments

@pierresouchay
Copy link
Contributor

Lookups in health are not case insensitive

Overview of the Issue

When doing some lookups on services, Consul is case sensitive when streaming is enabled

Reproduction Steps

Compare the output of those commands with Consul with streaming and without.

With streaming, lookups on health are not case insensitive, especially annoying for DNS.

To run Consul with streaming

consul agent -dev -hcl 'rpc{enable_streaming=true}' -hcl use_streaming_backend=true -hcl 'dns_config{ allow_stale=true, max_stale="3h", use_cache=true, "cache_max_age"="3h"}'

Test that should return 1 entry (notice the ConsuL case):

curl -fs --get "localhost:8500/v1/health/service/ConsuL?index=13&wait=5s&"
[]

=> BAD, should return 1 entry

pierresouchay added a commit to pierresouchay/consul that referenced this issue Feb 4, 2021
criteoconsul pushed a commit to criteo-forks/consul that referenced this issue Feb 4, 2021
@dnephin dnephin added theme/streaming Related to Streaming connections between server and client type/bug Feature does not function as expected labels Feb 4, 2021
pierresouchay added a commit to criteo-forks/consul that referenced this issue Feb 4, 2021
criteoconsul pushed a commit to criteo-forks/consul that referenced this issue Apr 22, 2021
criteoconsul pushed a commit to criteo-forks/consul that referenced this issue Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/streaming Related to Streaming connections between server and client type/bug Feature does not function as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants