Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated envoy name warnings #8425

Closed
rboyer opened this issue Jul 31, 2020 · 0 comments · Fixed by #9602
Closed

Fix deprecated envoy name warnings #8425

rboyer opened this issue Jul 31, 2020 · 0 comments · Fixed by #9602
Assignees
Labels
theme/envoy/xds Related to Envoy support

Comments

@rboyer
Copy link
Member

rboyer commented Jul 31, 2020

Since #8424 changed the supported min envoy version to v1.12.x I think we should be able to resolve a bunch of the following envoy deprecation warnings easily with a straight replacement.

If any of these deprecations were introduced after v1.12.x fixing these will require using the version sniffing logic recently added.

Deprecation Info:
https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated

Note this list is likely incomplete. For simplistic mesh scenarios these were just the first several that showed up in the envoy logs:

Cluster Fields

  • envoy.deprecated_features:envoy.api.v2.Cluster.tls_context: true
  • Using runtime overrides to continue using now fatal-by-default deprecated option 'envoy.api.v2.Cluster.tls_context' from file cluster.proto.
  • Using deprecated option 'envoy.api.v2.Cluster.hosts' from file cluster.proto.

HTTP

  • envoy.deprecated_features:envoy.config.trace.v2.ZipkinConfig.HTTP_JSON_V1: true
  • envoy.deprecated_features:envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager.Tracing.operation_name: true
  • Using runtime overrides to continue using now fatal-by-default deprecated option 'envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager.Tracing.operation_name' from file http_connection_manager.proto.

Listener Fields

  • Using deprecated option 'envoy.api.v2.listener.FilterChain.tls_context' from file listener_components.proto.
  • Using deprecated option 'envoy.api.v2.listener.Filter.config' from file listener_components.proto.

Extension Names

  • Using deprecated extension name 'envoy.tcp_proxy' for 'envoy.filters.network.tcp_proxy'.
  • Using deprecated extension name 'envoy.http_connection_manager' for 'envoy.filters.network.http_connection_manager'
  • Using deprecated extension name 'envoy.router' for 'envoy.filters.http.router'.
@rboyer rboyer added the theme/envoy/xds Related to Envoy support label Jul 31, 2020
@rboyer rboyer self-assigned this Jan 20, 2021
rboyer added a commit that referenced this issue Feb 11, 2021
Note that this does NOT upgrade to xDS v3. That will come in a future PR.

Additionally:

- Ignored staticcheck warnings about how github.com/golang/protobuf is deprecated.
- Shuffled some agent/xds imports in advance of a later xDS v3 upgrade.
- Remove support for envoy 1.13.x but don't add in 1.17.x yet. We have to wait until the xDS v3 support is added in a follow-up PR.

Fixes #8425
rboyer added a commit that referenced this issue Feb 19, 2021
Note that this does NOT upgrade to xDS v3. That will come in a future PR.

Additionally:

- Ignored staticcheck warnings about how github.com/golang/protobuf is deprecated.
- Shuffled some agent/xds imports in advance of a later xDS v3 upgrade.
- Remove support for envoy 1.13.x but don't add in 1.17.x yet. We have to wait until the xDS v3 support is added in a follow-up PR.

Fixes #8425
rboyer added a commit that referenced this issue Feb 22, 2021
Note that this does NOT upgrade to xDS v3. That will come in a future PR.

Additionally:

- Ignored staticcheck warnings about how github.com/golang/protobuf is deprecated.
- Shuffled some agent/xds imports in advance of a later xDS v3 upgrade.
- Remove support for envoy 1.13.x but don't add in 1.17.x yet. We have to wait until the xDS v3 support is added in a follow-up PR.

Fixes #8425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant