Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre-v0.8 ACL support #7292

Closed
mkeeler opened this issue Feb 13, 2020 · 0 comments · Fixed by #7991
Closed

Remove pre-v0.8 ACL support #7292

mkeeler opened this issue Feb 13, 2020 · 0 comments · Fixed by #7991
Labels
post-beta theme/acls ACL and token generation theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization
Milestone
1.8.0

Comments

@mkeeler
Copy link
Member

mkeeler commented Feb 13, 2020

Prior to v0.8 ACL enforcement in Consul didn't validate access to many different things. With v0.8 that changed and we have been supporting both ways since. We have defaulted to enforcing v0.8 ACLs for 9 major revisions and now is the time to remove that functionality all together.

This will involve editing just a few places in non-test code but is likely to involve more updating tests that happened to be using pre-v0.8 enforcement in the agent/consul package.
@mkeeler mkeeler added theme/acls ACL and token generation theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization labels Feb 13, 2020
@mkeeler mkeeler added this to the 1.8.0 milestone Feb 13, 2020
rboyer added a commit that referenced this issue May 29, 2020
@rboyer
acl: remove the deprecated acl_enforce_version_8 option
563aa44 
Fixes #7292
@rboyer rboyer mentioned this issue May 29, 2020
Merged
rboyer added a commit that referenced this issue May 29, 2020
@rboyer
acl: remove the deprecated acl_enforce_version_8 option (#7991)
ffb9c7d 
Fixes #7292
rboyer added a commit that referenced this issue Jun 1, 2020
@rboyer
acl: remove the deprecated acl_enforce_version_8 option (#7991)
c4b875c 
Fixes #7292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post-beta theme/acls ACL and token generation theme/internal-cleanup Used to identify tech debt, testing improvements, code refactoring, and non-impactful optimization
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

acl: remove the deprecated acl_enforce_version_8 option hashicorp/consul
2 participants
@preetapan @mkeeler