Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way for envoy sidecars to filter upstreams based on tags #11867

Open
apollo13 opened this issue Dec 16, 2021 · 4 comments
Open

Provide a way for envoy sidecars to filter upstreams based on tags #11867

apollo13 opened this issue Dec 16, 2021 · 4 comments
Labels
theme/envoy/xds Related to Envoy support type/enhancement Proposed improvement or new feature

Comments

@apollo13
Copy link
Contributor

Feature Description

It would be very cool if it were possible to tell consul connect envoy to filter upstreams based on tags. This would be useful if one has a service named backend exposing http & metrics instances so envoy could access only the http instances.

Use Case(s)

I am currently trying to put nomad behind an envoy proxy for certain things and nomad registers instances with the tags serf, rpc and http. Now I'd like to relatively easily tell envoy to be a proxy for the http tag. I do know that I can configure subsets on the service resolver and then add an extra service that routes to that, but that is quite some overhead…

@Amier3 Amier3 added theme/envoy/xds Related to Envoy support type/enhancement Proposed improvement or new feature labels Dec 16, 2021
@Amier3
Copy link
Contributor

Amier3 commented Jul 8, 2022

A little late on the response, but thanks for the feature request florian! I'll make sure we have a conversation about this internally and report back with some thoughts.

@apollo13
Copy link
Contributor Author

apollo13 commented Jul 8, 2022 via email

@apollo13
Copy link
Contributor Author

apollo13 commented Aug 2, 2022

So it seems like nomad is fixing this for my usecase via hashicorp/nomad#13143 -- didn't know that this was possible so easily (unless I missunderstood what the PR does).

@apollo13
Copy link
Contributor Author

apollo13 commented Aug 2, 2022

Also crosslinking to hashicorp/nomad#9914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants