Skip to content

Commit

Permalink
grpc: move gRPC INFO logs to be emitted as TRACE logs from Consul (#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
rboyer authored and hc-github-team-consul-core committed Jun 14, 2021
1 parent f6e3289 commit 976ed0f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .changelog/10395.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
grpc: move gRPC INFO logs to be emitted as TRACE logs from Consul
```
3 changes: 2 additions & 1 deletion logging/grpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ func NewGRPCLogger(logLevel string, logger hclog.Logger) *GRPCLogger {

// Info implements grpclog.LoggerV2
func (g *GRPCLogger) Info(args ...interface{}) {
g.logger.Info(fmt.Sprint(args...))
// gRPC's INFO level is more akin to Consul's TRACE level
g.logger.Trace(fmt.Sprint(args...))
}

// Infoln implements grpclog.LoggerV2
Expand Down
6 changes: 3 additions & 3 deletions logging/grpc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ func TestGRPCLogger(t *testing.T) {
grpclog.Errorf("Errorf: %d", 1)

// Fatal tests are hard... assume they are good!
expect := `timeformat [INFO] Info,
timeformat [INFO] Infoln
timeformat [INFO] Infof: 1
expect := `timeformat [TRACE] Info,
timeformat [TRACE] Infoln
timeformat [TRACE] Infof: 1
timeformat [WARN] Warning,
timeformat [WARN] Warningln
timeformat [WARN] Warningf: 1
Expand Down

0 comments on commit 976ed0f

Please sign in to comment.