Skip to content

Commit

Permalink
stragglers
Browse files Browse the repository at this point in the history
  • Loading branch information
analogue committed Aug 18, 2023
1 parent f8936c3 commit 246fe35
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion agent/consul/enterprise_server_ce.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (s *Server) validateEnterpriseIntentionNamespace(ns string, _ bool) error {
return nil
}

// No special handling for wildcard namespaces as they are pointless in OSS.
// No special handling for wildcard namespaces as they are pointless in CE.

return errors.New("Namespaces is a Consul Enterprise feature")
}
Expand Down
4 changes: 2 additions & 2 deletions test/integration/consul-container/libs/utils/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ var (
)

const (
DefaultImageNameOSS = "hashicorp/consul"
DefaultImageNameCE = "hashicorp/consul"
DefaultImageNameENT = "hashicorp/consul-enterprise"
ImageVersionSuffixENT = "-ent"
)
Expand Down Expand Up @@ -65,7 +65,7 @@ func TargetImages() topology.Images {
}
} else {
return topology.Images{
ConsulOSS: img,
ConsulCE: img,
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions testing/deployer/topology/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

type Images struct {
Consul string `json:",omitempty"`
ConsulOSS string `json:",omitempty"`
ConsulCE string `json:",omitempty"`
ConsulEnterprise string `json:",omitempty"`
Envoy string
Dataplane string
Expand Down Expand Up @@ -85,19 +85,19 @@ func (i Images) ChooseConsul(enterprise bool) Images {
if enterprise {
i.Consul = i.ConsulEnterprise
} else {
i.Consul = i.ConsulOSS
i.Consul = i.ConsulCE
}
i.ConsulEnterprise = ""
i.ConsulOSS = ""
i.ConsulCE = ""
return i
}

func (i Images) OverrideWith(i2 Images) Images {
if i2.Consul != "" {
i.Consul = i2.Consul
}
if i2.ConsulOSS != "" {
i.ConsulOSS = i2.ConsulOSS
if i2.ConsulCE != "" {
i.ConsulCE = i2.ConsulCE
}
if i2.ConsulEnterprise != "" {
i.ConsulEnterprise = i2.ConsulEnterprise
Expand All @@ -118,7 +118,7 @@ func (i Images) OverrideWith(i2 Images) Images {
func DefaultImages() Images {
return Images{
Consul: "",
ConsulOSS: DefaultConsulImage,
ConsulCE: DefaultConsulImage,
ConsulEnterprise: DefaultConsulEnterpriseImage,
Envoy: DefaultEnvoyImage,
Dataplane: DefaultDataplaneImage,
Expand Down

0 comments on commit 246fe35

Please sign in to comment.