Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terraform-exec version and consume WorkspaceNew #43

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

lornasong
Copy link
Member

@lornasong lornasong commented Sep 1, 2020

Changes:

  • Update to latest commit of terraform-exec
  • Add WorkspaceNew to terraformExec interface
  • Convert terraformExec interface to use generated mocks. Update associated tests
  • Update TerraformCLI client to consume terraform-exec’s WorkspaceNew() instead of temp hack

Resolves #39

@lornasong
Copy link
Member Author

Will wait to merge until after PR for #26 to avoid conflicts

@lornasong lornasong added this to the Technology Preview milestone Sep 1, 2020
Copy link
Contributor

@findkim findkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup PR ✨ ✨ ✨

- Update to latest commit of terraform-exec
- Add WorkspaceNew to terraformExec interface
- Convert terraformExec interface to use generated mocks. Update associated tests
- Update TerraformCLI client to consume terraform-exec’s WorkspaceNew() instead of temp hack
@lornasong lornasong merged commit 54412f9 into master Sep 1, 2020
@lornasong lornasong deleted the workspace-new branch September 1, 2020 18:21
sarahethompson pushed a commit that referenced this pull request Nov 6, 2023
Add LicenseManager to validate and watch license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use terraform-exec package to create new Terraform workspaces
2 participants