Fix - tests support consul 1.7 #1359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm debating about this one. Obviously we need to fix the test for 1.7+, but I prefer to keep compatibility with older versions whenever possible as I might need to debug things against older versions for some cases and don't want the test suite fighting me. |
|
@fredrikhgrelland Thanks for taking the time and trouble to fix and submit this! I've decided to fix it differently though, in a way that tests will still work with older versions. This helped me though by telling me exactly what was broken in the best way possible. So thanks so much for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since consul 1.7 the response for tagged addresses have changed.: hashicorp/consul#6531
This patch update tests to new 1.7 response syntax.