tests now use an external vault process #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikenb
force-pushed
the
vault-test-server
branch
from
2d6f9fb to
38a4740
Compare
greut
reviewed
Jul 16, 2019
eikenb
force-pushed
the
vault-test-server
branch
from
38a4740 to
a800b34
Compare
This was referenced Jul 16, 2019
Closed
eikenb
force-pushed
the
vault-test-server
branch
4 times, most recently
from
1169dea to
82d4870
Compare
eikenb
force-pushed
the
vault-test-server
branch
from
82d4870 to
a340fea
Compare
Replace use of core vault package for testing with an external vault process. Previously each set of tests that needed vault would create a vault service in the test process and all tests would use the default 'secret' kv path. Now it uses a separate kv secrets path for each set of tests, setting the version for each. The code for starting up the Vault process was based off what was already used for Consul via its sdk/testutils package. In the process various test conflicts were addressed and an external process (consul and vault) process leak was fixed [1]. [1] the leak was caused by use of log.Fatal which calls os.Exit which exist the process without running any cleanup code.
eikenb
force-pushed
the
vault-test-server
branch
from
a340fea to
494535a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of core vault package for testing with an external vault
process. Previously each set of tests that needed vault would create a
vault service in the test process and all tests would use the default
'secret' kv path. Now it uses a separate kv secrets path for each set of
tests, setting the version for each.
The code for starting up the Vault process was based off what was
already used for Consul via its sdk/testutils package.
In the process various test conflicts were addressed and an external
process (consul and vault) process leak was fixed [1].
[1] the leak was caused by use of log.Fatal which calls os.Exit which
exist the process without running any cleanup code.