Versioned KV support #1180
Merged
Versioned KV support #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearkes
reviewed
Feb 13, 2019
pearkes
reviewed
Feb 13, 2019
kyhavlov
force-pushed
the
versioned-secrets
branch
from
3caa27a to
3f4e28f
Compare
notnoop
pushed a commit
to notnoop/consul-template
that referenced
this pull request
Jul 16, 2019
When making unauthenticated secret lookup requests, ignore errors that result from checking the secret mount type. If it's a persistent error, the error on the actual lookup. This restores behavior to before hashicorp#1180 . A nomad enterprise customer hit this regression.
notnoop
pushed a commit
to notnoop/consul-template
that referenced
this pull request
Jul 16, 2019
When making unauthenticated secret lookup requests, ignore errors that result from checking the secret mount type. If it's a persistent error, the error on the actual lookup. This restores behavior to before hashicorp#1180 .
notnoop
pushed a commit
to notnoop/consul-template
that referenced
this pull request
Aug 9, 2019
When vault.read fails to determine whether a path is KVv2, assume it's KVv1 and read from the path as passed from user. Here we fallback to behavior prior to hashicorp#1180, so KVv2 check is for enhancement only. If user truely lacks access, the secret lookup call would fail and we report error back. A customer hit a regression after they upgraded nomad with updated consul-template, where their templates failed to read approle info because isKVv2 returned an error. The case is reproduced in `TestVaultReadQuery_Fetch_NonSecrets` test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading secrets from the v2 KV secrets engine in Vault.
Fixes #1121
Fixes #1146