Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: bump golang.org/x/sys dependency #781

Merged
merged 1 commit into from
Oct 14, 2021
Merged

cli: bump golang.org/x/sys dependency #781

merged 1 commit into from
Oct 14, 2021

Conversation

ndhanushkodi
Copy link
Contributor

See golang/go#46763. The CLI would error at
runtime after being compiled with go 1.17, unless the x/sys dependency
is bumped.

How I've tested this PR:

  • upgraded to go 1.17.2
  • Ran go build . -o consul-k8s
  • ./consul-k8s version
    How I expect reviewers to test this PR:
  • build and run the cli like above with go 1.17.x and check that it works

Checklist:

  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ndhanushkodi
cli: bump golang.org/x/sys dependency
d5b744c 
See golang/go#46763. The CLI would error at
runtime after being compiled with go 1.17, unless the x/sys dependency
is bumped.
@ndhanushkodi ndhanushkodi requested review from a team, ishustava, sadjamz and kschoche and removed request for a team October 14, 2021 16:33
kschoche
kschoche approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, assuming everything passes :)
Are we still specifying go-1.16?

t-eckert
t-eckert approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, This passed for both 1.16 and 1.17.

@ndhanushkodi ndhanushkodi merged commit 242a9d2 into main Oct 14, 2021
@ndhanushkodi ndhanushkodi deleted the cli-go1.17-fix branch October 14, 2021 19:52
@ndhanushkodi
Copy link
Contributor Author

@kschoche yes the go mod should still specify 1.16 but if people do build with 1.17 we should see it work!

ottaviohartman pushed a commit to ottaviohartman/consul-k8s that referenced this pull request Nov 3, 2021
@ndhanushkodi
Release 0.29.0, update changelog and values (hashicorp#781)
02b30f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschoche kschoche kschoche approved these changes

@t-eckert t-eckert t-eckert approved these changes

@ishustava ishustava Awaiting requested review from ishustava

@sadjamz sadjamz Awaiting requested review from sadjamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndhanushkodi @kschoche @t-eckert