add arm64 #98
Merged
add arm64 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hey @varnson, thanks for submitting this. To add arm64 it needs a few additional changes to exclude unsupported platforms. Probably easiest for you to just look at what consul-template does as it already has arm64 support and excludes all the necessary platforms (probably more than needed here). You should be able to just specify the "arm64" exclusions just like it does in consul-template's Makefile, as it does the same comparison. |
|
@eikenb |
|
Sorry @varnson, but would you mind including the comment that was above the XC_EXCLUDE definition. Makefiles can be pretty dense and it is not obvious how that comparison works. Thanks. |
eikenb
reviewed
Jan 7, 2021
|
Looks good. Thanks for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #88
add arm64