Add a configurable http metrics interface #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edevil
force-pushed
the
metrics_interface
branch
3 times, most recently
from
896d01e to
d0f849d
Compare
lornasong
reviewed
Oct 30, 2020
lornasong
reviewed
Nov 4, 2020
README.md
Outdated
| @@ -242,6 +242,9 @@ https_cert_file = "" | |||
| // The client key file to use for talking to HTTPS checks. | |||
| https_key_file = "" | |||
|
|
|||
| // Client address. Example: "127.0.0.1:8080" | |||
There was a problem hiding this comment.
I'd like to add a little more information here so that users will know when they should configure this. Maybe something like: "Client address to expose API endpoints. Required in order to expose /metrics endpoint for Prometheus." Feel free to use any other language you prefer!
There was a problem hiding this comment.
I agree, I followed your language suggestion.
Expose http endpoint so that metrics can be collected. Only used for Prometheus metrics for now.
edevil
force-pushed
the
metrics_interface
branch
from
2e210bd to
d532578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose http endpoint so that metrics can be collected. Only used
for Prometheus metrics for now.
Adresses #89