Don't check the status when syncing a new check #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status is managed outside of the check itself, and should at times be different this is very true when a check is going from passing->failing or visa versa.
lornasong
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
@mikeyyuen - thanks for fixing this! agree that the status should not be checked when syncing checks and only be when updating the status in catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status is managed outside of the check itself.
That means when the status is changing due to a failure or recovery of a service it's status may be different than the one in the catalog. Checking status in the
update*functions may cause the service to flap during an outage rather then transition cleanly to failing.This change removes the extra status check in the
update*functions.