Make ESM Instance ID Configurable #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findkim
approved these changes
May 13, 2020
|
@findkim - great point, I added the new config to the |
lornasong
force-pushed
the
issue-60-config-id
branch
from
19d9e08 to
a263589
Compare
Feature request to allow practitioners to set instance ids in order for ESM instances to terminate and reregister with Consul with the same id. Ungraceful terminations currently take 30 minutes to be reaped. Without this feature, when a new instance starts up, it has a new id and leads to multiple ESM instances rather than 'replacing' the terminated one. - Add instance_id in configuration file - Replace existing `id` used for testing with instance_id - Add a check to ensure instance_id is unique since we are no longer generating a unique id on behalf of the practitioner
lornasong
force-pushed
the
issue-60-config-id
branch
from
a25005a to
2e60fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request to allow practitioners to set instance ids in order for ESM
instances to terminate and reregister with Consul with the same id. Ungraceful
terminations currently take 30 minutes to be reaped. Without this feature, when
a new instance starts up, it has a new id and leads to multiple ESM instances
rather than 'replacing' the terminated one.
idused for testing with instance_ida unique id on behalf of the practitioner
Resolves #60