Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-ping to 1.0.0 to fix deadlock #129

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented May 13, 2022

also addresses some other scaling issues

Fixes #86

also addresses some other scaling issues
@eikenb eikenb added the bug label May 13, 2022
@eikenb eikenb added this to the v0.6.1 milestone May 13, 2022
@eikenb eikenb requested a review from a team May 13, 2022 19:28
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

@eikenb eikenb merged commit 3a07152 into main May 16, 2022
@eikenb eikenb deleted the issue-86-go-ping-update branch May 16, 2022 18:50
@eikenb
Copy link
Contributor Author

eikenb commented May 16, 2022

Thanks @lornasong. Not really PR worthy, but had the github issue I wanted to close and I like using PRs to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock in go-ping
2 participants