Backport of proxy-lifecycle: add HTTP Server with endpoints for proxy lifecycle shutdown into release/1.0.x #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
curtbushko
commented
Jun 27, 2023
•
curtbushko
commented
- Manual backport of proxy-lifecycle: add HTTP Server with endpoints for proxy lifecycle shutdown #115
…hutdown (#115) * envoy: set drain time and strategy passthrough config with sensible defaults for sidecar proxy shutdown lifecycle * pkg/consuldp/lifecycle: wire up lifecycle mgmt server into consul-dataplane main config * pkg/envoy: add Drain and Quit methods, rename Stop to Kill * pkg/consuldp/lifecycle: gracefully shutdown Envoy if xDS or lifecycle mgmt server exits unexpectedly * ci: disable parallelism in unit tests to avoid port conflicts * pkg/envoy: add http client to dial Envoy admin interface * pkg/consuldp/lifecycle: replace http client with proxy manager interface and mock * test/lifecycle: pick an available port if gracefulPort is unspecified * pkg/consuldp/lifecycle: check errors and close errorExitCh if any problems gracefully shutting down Envoy * add changelong --------- Co-authored-by: Nathan Coleman <[email protected]> Co-authored-by: Paul Glass <[email protected]>
curtbushko
changed the title
wilkermichael
approved these changes
Jun 27, 2023
wilkermichael
pushed a commit
that referenced
this pull request
Jun 28, 2023
… lifecycle shutdown into release/1.0.x (#182) * proxy-lifecycle: add HTTP Server with endpoints for proxy lifecycle shutdown (#115) * envoy: set drain time and strategy passthrough config with sensible defaults for sidecar proxy shutdown lifecycle * pkg/consuldp/lifecycle: wire up lifecycle mgmt server into consul-dataplane main config * pkg/envoy: add Drain and Quit methods, rename Stop to Kill * pkg/consuldp/lifecycle: gracefully shutdown Envoy if xDS or lifecycle mgmt server exits unexpectedly * ci: disable parallelism in unit tests to avoid port conflicts * pkg/envoy: add http client to dial Envoy admin interface * pkg/consuldp/lifecycle: replace http client with proxy manager interface and mock * test/lifecycle: pick an available port if gracefulPort is unspecified * pkg/consuldp/lifecycle: check errors and close errorExitCh if any problems gracefully shutting down Envoy * add changelong --------- Co-authored-by: Nathan Coleman <[email protected]> Co-authored-by: Paul Glass <[email protected]> * fix automation * fix unit tests --------- Co-authored-by: Mike Morris <[email protected]> Co-authored-by: Nathan Coleman <[email protected]> Co-authored-by: Paul Glass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.