Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow all of IAT, NBF, and EXP to be missing #50

Merged
merged 4 commits into from
May 2, 2022

Conversation

swenson
Copy link
Contributor

@swenson swenson commented May 2, 2022

This is necessary for Kubernetes 1.20 auth tokens, which don't include any of iat/exp/nbf, so this library has no way to deal with them. (Which blocks vault-plugin-auth-kubernetes from using this library, since we still support Kubernetes 1.20.)

Also did a small amount of cleanup:

  • Generate a single 4096-bit RSA key in the tests, which speeds them up by a few seconds.
  • Update go.mod in ldap cli example to use commit that exists (otherwise the tests appear to fail)

Christopher Swenson added 2 commits May 2, 2022 10:08
This is necessary for Kubernetes 1.20 auth tokens, which don't include
any of `iat`/`exp`/`nbf`, so this library has no way to deal with them.

Also only generate a single 4096-bit RSA key in the tests, which speeds
them up by a few seconds.
@swenson swenson requested a review from austingebauer May 2, 2022 20:09
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks, @swenson.

jwt/jwt.go Outdated Show resolved Hide resolved
jwt/jwt_test.go Show resolved Hide resolved
@swenson
Copy link
Contributor Author

swenson commented May 2, 2022

Thanks!

@swenson swenson merged commit 9a9f4a9 into main May 2, 2022
@swenson swenson deleted the VAULT-5829-ignore-missing-iat-exp-nbf branch May 2, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants