Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (oidc): add WithVerifier #141

Merged
merged 2 commits into from
Oct 22, 2024
Merged

feat (oidc): add WithVerifier #141

merged 2 commits into from
Oct 22, 2024

Conversation

jimlambrt
Copy link
Collaborator

This commit adds the WithVerifier option to the
oidc package. This option allows the user to
specify a custom verifier for the PKCE code
challenge.

This commit adds the WithVerifier option to the
oidc package. This option allows the user to
specify a custom verifier for the PKCE code
challenge.
@jimlambrt jimlambrt requested a review from hcjulz as a code owner October 22, 2024 13:35
@jimlambrt jimlambrt requested a review from alexmunda October 22, 2024 13:36
Copy link
Collaborator

@alexmunda alexmunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition

Copy link
Collaborator

@hcjulz hcjulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jimlambrt jimlambrt merged commit 67f22c4 into main Oct 22, 2024
6 checks passed
@jimlambrt jimlambrt deleted the jimlambrt-with-verifier branch October 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants