Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case insensitive user attribute keys configs for LDAP #132

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

jasonodonnell
Copy link
Contributor

Vault relies on case insensitive user attribute keys for mapping user attributes to entity alias metadata. This adds configs to allow the callers to specify how the attribute keys should be returned.

@jasonodonnell jasonodonnell requested a review from jimlambrt March 27, 2024 18:23
Copy link
Collaborator

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. couple minor things.

ldap/options.go Outdated Show resolved Hide resolved
ldap/client.go Show resolved Hide resolved
Copy link
Collaborator

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@jasonodonnell jasonodonnell merged commit 0d02560 into main Mar 27, 2024
5 of 8 checks passed
@jasonodonnell jasonodonnell deleted the ldap-userattrs-tolower branch March 27, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants