improving / fixing comments and var names

hashicorp · Dec 6, 2024 · c4af8fc · c4af8fc
1 parent c9cf0d9
commit c4af8fc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/saml/response_test.go b/saml/response_test.go
@@ -68,14 +68,14 @@ func TestServiceProvider_ParseResponse(t *testing.T) {
 		{
 			name:      "success - with just response signed",
 			sp:        testSp,
-			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseElemSigned()))),
+			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseSigned()))),
 			opts:      []saml.Option{},
 			requestID: testRequestId,
 		},
 		{
 			name:      "success - with just assertion signed",
 			sp:        testSp,
-			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionElemSigned()))),
+			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionSigned()))),
 			opts:      []saml.Option{},
 			requestID: testRequestId,
 		},
@@ -89,14 +89,14 @@ func TestServiceProvider_ParseResponse(t *testing.T) {
 		{
 			name:      "success - with option validate response signature and with only response signed",
 			sp:        testSp,
-			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseElemSigned()))),
+			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseSigned()))),
 			opts:      []saml.Option{saml.ValidateResponseSignature()},
 			requestID: testRequestId,
 		},
 		{
 			name:      "success - with option validate assertion signature and with only assertion signed",
 			sp:        testSp,
-			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionElemSigned()))),
+			samlResp:  base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionSigned()))),
 			opts:      []saml.Option{saml.ValidateAssertionSignature()},
 			requestID: testRequestId,
 		},
@@ -111,31 +111,31 @@ func TestServiceProvider_ParseResponse(t *testing.T) {
 		{
 			name:            "error-invalid-signature - with option validate both signatures and with just response signed",
 			sp:              testSp,
-			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseElemSigned()))),
+			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseSigned()))),
 			opts:            []saml.Option{saml.ValidateResponseAndAssertionSignatures()},
 			requestID:       testRequestId,
 			wantErrContains: "invalid signature",
 		},
 		{
 			name:            "error-invalid-signature - with option validate both signatures and with just assertion signed",
 			sp:              testSp,
-			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionElemSigned()))),
+			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionSigned()))),
 			opts:            []saml.Option{saml.ValidateResponseAndAssertionSignatures()},
 			requestID:       testRequestId,
 			wantErrContains: "invalid signature",
 		},
 		{
 			name:            "error-invalid-signature - with option validate response signature and with just assertion signed",
 			sp:              testSp,
-			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionElemSigned()))),
+			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustAssertionSigned()))),
 			opts:            []saml.Option{saml.ValidateResponseSignature()},
 			requestID:       testRequestId,
 			wantErrContains: "invalid signature",
 		},
 		{
 			name:            "error-invalid-signature -with option validate assertion signature and with just response signed",
 			sp:              testSp,
-			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseElemSigned()))),
+			samlResp:        base64.StdEncoding.EncodeToString([]byte(tp.SamlResponse(t, testprovider.WithJustResponseSigned()))),
 			opts:            []saml.Option{saml.ValidateAssertionSignature()},
 			requestID:       testRequestId,
 			wantErrContains: "invalid signature",

diff --git a/saml/test/provider.go b/saml/test/provider.go
@@ -458,13 +458,13 @@ func WithResponseAndAssertionSigned() ResponseOption {
 	}
 }
 
-func WithJustAssertionElemSigned() ResponseOption {
+func WithJustAssertionSigned() ResponseOption {
 	return func(o *responseOptions) {
 		o.signAssertionElem = true
 	}
 }
 
-func WithJustResponseElemSigned() ResponseOption {
+func WithJustResponseSigned() ResponseOption {
 	return func(o *responseOptions) {
 		o.signResponseElem = true
 	}