Update CLI error codes to be consistent with connect
#976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
force-pushed
the
jeff-update-cli-error-codes
branch
from
57404c9 to
1787fcd
Compare
louisruch
reviewed
Mar 4, 2021
There was a problem hiding this comment.
nit: given we are standardizing return codes here, it would be nice if they could be made consts instead of magic numbers within the code. This will just help future coding and debugging to quickly know what each means.
Feel free to add this as a backlog task as well
|
@louisruch great idea on the consts; I will make that change now. |
|
@louisruch done, PTAL |
louisruch
approved these changes
Mar 5, 2021
louisruch
pushed a commit
that referenced
this pull request
Apr 7, 2024
This adds an enterprise-specific scenario for running Admin UI tests against AWS infra. This enables testing for features like session recording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.