-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI JSON updates #962
CLI JSON updates #962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good.
I am a little bummed (but only a little) that we are deciding to expose the underlying response instead of targeting more precisely the data we want to expose since, in my mind, the fact we use http is an implementation detail which could be hidden.
@jefferai one change I noticed is that errors are now printed to |
Errors back on stderr as discussed. |
* Add GetAliases and SetAliases on ssh targets
NOTE: Before I merge this I will separate it into two separate PRs -- one that updates the
api
bits (and then tag it), and another that then uses that new API tag with the main repo bits. I will also add the changelog notices then as well.This makes the following changes:
item
key and a list is under theitems
key. Additionally, the status code is returned in the top level object asstatus_code
, because (a) why not and (b) it gives a clear (and potentially useful) example for why we're making this changeerror
key.error
key, a status code, and the raw API error itself in theapi_error
key.http.Response
so it felt more canonical.