Events: convert from hclog to events #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature flag BOUNDARY_DEVELOPER_ENABLE_EVENTS
vancluever
previously approved these changes
Jul 26, 2021
…ller and workers for things like tickers, jobs and status
…ith a timeout. otherwise the event broker doesn't properly track success thresholds and we get false positive errors
|
Reviewers: I'm calling out a few specific commits for re-review:
|
|
@tmessi ty! I've converted them to references. @louisruch I've refactored the remaining calls to Start(...) in the tests. ty! |
tmessi
reviewed
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all the existing logging to events. The PR shouldn't be merged until #1390 is merged and we're ready for events to be generally available.
In that vein, this PR removes the BOUNDARY_DEVELOPER_ENABLE_EVENTS from events.WriteSysEvent(...), event.WriteObservation(...) and event.WriteError(...) but it keeps it in place for WriteAudit(...) which means audit events will not be enabled by this PR.
Contributors which relied on trace, debug and warn logging for instrumentation are encouraged to review the conversion of their logging contributions to events.
Note: the conversion from logging to events means that log levels are not longer a thing in Boundary and operators will need to use event filtering to control which events are emitted.