Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing API-level state checks during session cancel #1223

Merged
merged 2 commits into from
May 14, 2021
Merged

Add missing API-level state checks during session cancel #1223

merged 2 commits into from
May 14, 2021

Conversation

jefferai
Copy link
Member

This validates it's not already canceled or in terminated state.

@jefferai
Add missing API-level state checks during session cancel
fa5214a 
This validates it's not already canceled or in terminated state.
@jefferai jefferai added this to the 0.2.2 milestone May 14, 2021
@jefferai jefferai requested review from louisruch and mgaffney May 14, 2021 18:43
louisruch
louisruch approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefferai jefferai merged commit b54be8e into main May 14, 2021
@jefferai jefferai deleted the jeff-api-cancel-state-checks branch May 14, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaffney mgaffney mgaffney approved these changes

@louisruch louisruch louisruch approved these changes

Assignees
No one assigned
Labels
core/servers core
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @mgaffney @louisruch