Add cleanup of dead connections no longer reported by a worker #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
core/db
core/gen
core/proto
core/servers
core/session
core/sql
labels
mgaffney
previously requested changes
May 13, 2021
Co-authored-by: Michael Gaffney <[email protected]>
louisruch
previously approved these changes
May 13, 2021
hugoghx
pushed a commit
that referenced
this pull request
Dec 6, 2024
* internal/daemon/controller+worker: propagate downstream timeout Propagate the downstream worker timeout into the downstream receiver and downstream ticker so we have a configurable consistent timeout value to use for worker to worker interactions. Also change the atomic.Pointer to an atomic.Int64 for consistency with other values. * internal: propagate downstream timeout The downstream worker timeout is now used in all time bound operations between workers. * address lint and test failures --------- Co-authored-by: irenarindos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a worker no longer reports a connection (e.g. after a restart), the controller will now mark those connections as closed so that sessions can be terminated instead of sitting in canceling state due to stuck connections.
Related to #894
Related to #1055